[
https://issues.apache.org/jira/browse/DBCP-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068061#comment-13068061
]
James Howe commented on DBCP-351:
---------------------------------
Re. Dain's comment, there's only a transaction open if one has sent BEGIN
without then sending COMMIT/ROLLBACK, which should always have been done on
return to pool.
Would overall performance not be better if new connections are added to the
pool to replace disconnected ones, rather than adding all this extra traffic on
every request so that the existing connections can use autoReconnect?
> setAutoCommit called too many times
> -----------------------------------
>
> Key: DBCP-351
> URL: https://issues.apache.org/jira/browse/DBCP-351
> Project: Commons Dbcp
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: OD
> Fix For: 2.0
>
>
> passivateObject in PoolableConnectionFactory sets autoCommit to true, even if
> defaultAutoCommit is set to false. This results in two extra db queries for
> every use of the connection (set false, do work, set true). This creates a
> significant amount of overhead, even if the connection is never even used.
> I propose it be changed to:
> if(conn.getAutoCommit() != _defaultAutoCommit)
> {
> conn.setAutoCommit(_defaultAutoCommit);
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
