[
https://issues.apache.org/jira/browse/OGNL-8?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119656#comment-13119656
]
Christian Grobmeier edited comment on OGNL-8 at 10/3/11 9:52 PM:
-----------------------------------------------------------------
Daniel, i tried to include your patches. So far it looks like the right
direction. I have even managed to compile it one time. But mvn test fails
because of unresolved compilation failures. My assumption is that the generated
sources are not put on the classpath when the mvn test runs. Can you confirm
that?
Another problem is Eclipse (at least for me). You generate into the target
folder, which is surely correct, but did you somehow manage to add the
generated sources on your ides classpath? (assuming you do not use Notepad and
mvn only hehe :-))
I made a similar page this evening before I read you message. I have generated
it into the src/main/java/.../javacc package which at least does solve the
eclipse problem. My suggestion is we reenable code generation first and then
care about the maven problems. What do you think?
Any hints to make your patch working are very welcome of course.
was (Author: cgrobmeier):
Daniel, i tried to include your second patch (assuming the first one is
already in svn - could not find any differences). So far it looks like the
right direction. I have even managed to compile it one time. But mvn test fails
because of unresolved compilation failures. My assumption is that the generated
sources are not put on the classpath when the mvn test runs. Can you confirm
that?
Another problem is Eclipse (at least for me). You generate into the target
folder, which is surely correct, but did you somehow manage to add the
generated sources on your ides classpath? (assuming you do not use Notepad and
mvn only hehe :-))
I made a similar page this evening before I read you message. I have generated
it into the src/main/java/.../javacc package which at least does solve the
eclipse problem. My suggestion is we reenable code generation first and then
care about the maven problems. What do you think?
Any hints to make your patch working are very welcome of course.
> use javacc to generate AST* and OGNLParser Java sources
> -------------------------------------------------------
>
> Key: OGNL-8
> URL: https://issues.apache.org/jira/browse/OGNL-8
> Project: OGNL
> Issue Type: Task
> Reporter: Olivier Lamy
> Assignee: Olivier Lamy
> Attachments: OGNL-8-keep-custom-AST.patch, OGNL-8.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
