[ https://issues.apache.org/jira/browse/OGNL-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13127351#comment-13127351 ]
Hudson commented on OGNL-21: ---------------------------- Integrated in ognl #134 (See [https://builds.apache.org/job/ognl/134/]) OGNL-21: change added OGNL-21: fixed unused imports, some dead code, unused variables OGNL-21: fixed some dead code OGNL-21: fixed dead code grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1183236 Files : * /commons/proper/ognl/trunk/src/changes/changes.xml grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1183235 Files : * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/ArrayElementsTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/ContextVariableTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/CorrectedObjectNullHandler.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/IndexAccessTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/InterfaceInheritanceTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/LambdaExpressionTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/MethodWithConversionTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/NestedMethodTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/NullHandlerTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/OperatorTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/Performance.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/PrivateAccessorTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/PropertyTest.java * /commons/proper/ognl/trunk/src/test/java/org/apache/commons/ognl/test/QuotingTest.java grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1183233 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/OgnlRuntime.java grobmeier : http://svn.apache.org/viewvc/?view=rev&rev=1183231 Files : * /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTStaticField.java > Remove dead and broken code from OgnlRuntime/SimpleNode > ------------------------------------------------------- > > Key: OGNL-21 > URL: https://issues.apache.org/jira/browse/OGNL-21 > Project: OGNL > Issue Type: Task > Reporter: Daniel Pitts > Labels: cleanup > Attachments: Remove-dead-code.patch > > > I noticed there are some apparently unnecessary methods in both SimpleNode > and OgnlRuntime. > I've created a patch which removes them, and the unit tests still run fine. > One of the methods was clearly buggy and would cause ClassCastExceptions if > used (it put an array into a cache which was used to also store Maps). -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira