[ 
https://issues.apache.org/jira/browse/OGNL-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13139259#comment-13139259
 ] 

Adrian Cumiskey commented on OGNL-33:
-------------------------------------

Hi Maurizio,

I also noticed that this class was previously created by javacc.  I looked 
through the codebaee and could not find the source of the generation.  My guess 
is that it is no longer generated otherwise the class would most likely have 
resided in the generated/src tree. Perhaps we could now remove the generation 
comments?  Thanks again for your timely processing of my patches.

Cheers, Adrian.
                
> [PATCH] Improvements to JJTOgnlParserState
> ------------------------------------------
>
>                 Key: OGNL-33
>                 URL: https://issues.apache.org/jira/browse/OGNL-33
>             Project: OGNL
>          Issue Type: Improvement
>            Reporter: Adrian Cumiskey
>            Assignee: Maurizio Cucchiara
>            Priority: Minor
>         Attachments: patch-OGNL33.txt
>
>
> JJTOgnlParserState was looking a little old school.
> * Introduced generics on the "nodes" and "marks" List.
> * Replaced 1-3 character acronyms with meaningful, camel case variable names.
> * Removed unnecessary use of (un)boxing. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to