[
https://issues.apache.org/jira/browse/OGNL-37?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142990#comment-13142990
]
Hudson commented on OGNL-37:
----------------------------
Integrated in ognl #180 (See [https://builds.apache.org/job/ognl/180/])
OGNL-37 - Provide equals() and hashcode() implementation to override
PropertyDescriptor.
OGNL-37 - Use StringBuilder instead of String concatenation with '+'.
OGNL-37 - Use StringBuilder instead of String concatenation with '+'.
OGNL-37 - Replaced for loops with foreach version.
OGNL-37 - Remove int boxing, lets rely on autoboxing.
OGNL-37 - Remove unnecessary int boxing and redundant code.
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197018
Files :
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ObjectIndexedPropertyDescriptor.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197015
Files :
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ExpressionNode.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197014
Files :
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTMethod.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197011
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTChain.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197009
Files :
* /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ASTChain.java
mcucchiara : http://svn.apache.org/viewvc/?view=rev&rev=1197007
Files :
*
/commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/ArrayPropertyAccessor.java
> [PATCH] Findbugs fixes
> ----------------------
>
> Key: OGNL-37
> URL: https://issues.apache.org/jira/browse/OGNL-37
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Priority: Minor
> Attachments: patch-OGNL37.txt
>
>
> ExpressionNode: Use StringBuilder instead of String concatenation with '+'.
> ObjectIndexedPropertyDescriptor: Provide equals() and hashcode()
> implementation to override PropertyDescriptor.
> ExpressionCompiler: Remove redundant attempt to remove LocalReference key
> (keys are always of type String).
> ASTMethod: Use StringBuilder instead of String concatenation with '+'.
> DeclaredMethodCacheEntry: Modified equals() implementation to take account of
> super class fields.
> OgnlRuntime: Made static ints final. Use Map.entrySet instead of Map.keySet
> for better performance. Javadoc improvements.
> ASTChain: Remove int boxing, lets rely on autoboxing.
> ArrayPropertyAccessor: Remove unnecessary int boxing and redundant code.
> OgnlOps: use valueOf() instead of new for boxing. Adjust unnecessary
> conditional checking.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
