[
https://issues.apache.org/jira/browse/OGNL-35?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13143875#comment-13143875
]
Maurizio Cucchiara commented on OGNL-35:
----------------------------------------
Thanks Adrian for the patch.
Just a little note: next time, could you please follow the [maven code
style|http://maven.apache.org/developers/conventions/code.html] conventions?
> [PATCH] Improvements to {List,Map,Array}PropertyAccessor and ASTProperty
> ------------------------------------------------------------------------
>
> Key: OGNL-35
> URL: https://issues.apache.org/jira/browse/OGNL-35
> Project: OGNL
> Issue Type: Improvement
> Reporter: Adrian Cumiskey
> Priority: Minor
> Attachments: patch-OGNL35-v2.txt, patch-OGNL35.txt
>
>
> * Flipped equals() everywhere where a variable is tested against a String
> constant.
> * ListPropertyAccessor: CPD fix, extracted shared method
> getSourceBeanMethod() from getSourceSetter() and getSourceAccessor().
> * ASTProperty: CPD fix, extracted shared method getSourceString() from
> toGetSourceString() and toSetSourceString().
> * ArrayPropertyAccessor: CPD fix, extracted getIndexString() from
> getSourceAccessor() and getSourceSetter().
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
