[ https://issues.apache.org/jira/browse/MATH-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sébastien Brisard updated MATH-677: ----------------------------------- Description: Classes in package "o.a.c.m.transform" might require some changes in order to conform to goals set for the next major release. Some observations: # Exceptions ## Should remove use of deprecated "MathRuntimeException" ## Should throw more specific "Math...Exception" instances instead of standard IAE # Interface "RealTransformer" (and implementations) contain non-conformant method names (e.g. "inversetransform" instead of "inverseTransform") # "FastFourierTransformer": ## Methods "mdfft" and "verifyDataSet" take an argument of type "Object" (to allow an argument with an unspecified number of dimensions) ## The "RootsOfUnity" helper class could be moved to the "complex" package ## For clarity, multidimensional transform should be moved to a class of its own (and I also wonder whether the "MultiDimensionalComplexMatrix" name is not misleading) # "FastFourierTransformer", "FastSineTranformer" and "FastCosineTranformer" define public methods "tranform2" and "inversetransform2" but they are not part of an interface # Code uses variables that start with an uppercase # "FastHadamardTransformer" contains illegible developer documentation (see Javadoc for protected method "fht") was: Classes in package "o.a.c.m.transform" might require some changes in order to conform to goals set for the next major release. Some observations: * Exceptions ** Should remove use of deprecated "MathRuntimeException" ** Should throw more specific "Math...Exception" instances instead of standard IAE * Interface "RealTransformer" (and implementations) contain non-conformant method names (e.g. "inversetransform" instead of "inverseTransform") * "FastFourierTransformer": ** Methods "mdfft" and "verifyDataSet" take an argument of type "Object" (to allow an argument with an unspecified number of dimensions) ** The "RootsOfUnity" helper class could be moved to the "complex" package ** For clarity, multidimensional transform should be moved to a class of its own (and I also wonder whether the "MultiDimensionalComplexMatrix" name is not misleading) * "FastFourierTransformer", "FastSineTranformer" and "FastCosineTranformer" define public methods "tranform2" and "inversetransform2" but they are not part of an interface * Code uses variables that start with an uppercase * "FastHadamardTransformer" contains illegible developer documentation (see Javadoc for protected method "fht") > About package "transform" > ------------------------- > > Key: MATH-677 > URL: https://issues.apache.org/jira/browse/MATH-677 > Project: Commons Math > Issue Type: Improvement > Reporter: Gilles > Priority: Minor > Labels: api-change > Fix For: 3.0 > > > Classes in package "o.a.c.m.transform" might require some changes in order to > conform to goals set for the next major release. > Some observations: > # Exceptions > ## Should remove use of deprecated "MathRuntimeException" > ## Should throw more specific "Math...Exception" instances instead of > standard IAE > # Interface "RealTransformer" (and implementations) contain non-conformant > method names (e.g. "inversetransform" instead of "inverseTransform") > # "FastFourierTransformer": > ## Methods "mdfft" and "verifyDataSet" take an argument of type "Object" (to > allow an argument with an unspecified number of dimensions) > ## The "RootsOfUnity" helper class could be moved to the "complex" package > ## For clarity, multidimensional transform should be moved to a class of its > own (and I also wonder whether the "MultiDimensionalComplexMatrix" name is > not misleading) > # "FastFourierTransformer", "FastSineTranformer" and "FastCosineTranformer" > define public methods "tranform2" and "inversetransform2" but they are not > part of an interface > # Code uses variables that start with an uppercase > # "FastHadamardTransformer" contains illegible developer documentation (see > Javadoc for protected method "fht") -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira