[ 
https://issues.apache.org/jira/browse/CHAIN-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162071#comment-13162071
 ] 

Simone Tripodi commented on CHAIN-58:
-------------------------------------

Hi Elijah!

just to keep you updated how I am reviewing the patch: the main point IMHO is 
that the signature {{interface Command<C extends Context<?, ?>>}} circumvents 
the benefit of having Generics in the {{Context}}, I think that as user we have 
to get benefits inside the {{Command}} instances since we don't have to know 
which key/value type while performing the {{execute()}} method.

So, I would like to move to a less type agnostic {{Command}} implementation: 
what's your opinion about that?
Many thanks in advance!
                
> Update Chain Context interface to use K,V generics
> --------------------------------------------------
>
>                 Key: CHAIN-58
>                 URL: https://issues.apache.org/jira/browse/CHAIN-58
>             Project: Commons Chain
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Elijah Zupancic
>             Fix For: 2.0
>
>         Attachments: chain-58.diff
>
>
> As discussed in the mailing list, I am suggesting that we change the 
> definition of Context from:
> {noformat}
> public interface Context extends Map<String, Object> {
> {noformat}
> to:
> {noformat}
> public interface Context<K, V> extends Map<K, V> {
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to