[
https://issues.apache.org/jira/browse/MATH-730?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182404#comment-13182404
]
Sébastien Brisard commented on MATH-730:
----------------------------------------
{quote}
One small issue: RandomDataImpl.nextUniform(double, double) has different
@throws (exception class and message) than nextUniform(double, double,
boolean). They should probably be identical, as one calls the other.
{quote}
You're right, changed in {{r1229048}}. Thanks for pointing that out!
{quote}
And one question: What is the reason for not including the @throws for the 2
methods in the interface as well? Don't we expect all implementations to
conform to that exception in that exact case? That would allow users to catch
it, regardless of the actual implementation class.
{quote}
I know. While reviewing your patch, I actually noticed that nowhere in the
{{RandomData}} interface were the exceptions specified. For the sake of
homogeneity, I did the same with the two flavours of {{nextDouble}}, making a
mental note about a more thorough cleaning up of the whole interface. One more
point which I'll keep in mind when I do that
??All public methods advertise all exceptions that they can generate.
Exceptions must be documented in {color:red}both javadoc and method
signatures{color} and the documentation in the javadoc must include full
description of the conditions under which exceptions are thrown.??
(see developers guide).
I'll dive into it in the coming days, if that's OK with you.
> Add uniform distributions (integer and real)
> --------------------------------------------
>
> Key: MATH-730
> URL: https://issues.apache.org/jira/browse/MATH-730
> Project: Commons Math
> Issue Type: New Feature
> Reporter: Dennis Hendriks
> Labels: distribution
> Fix For: 3.0
>
> Attachments: uniform-distributions.patch
>
>
> Add UniformIntegerDistribution and UniformRealDistribution classes.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
