[ https://issues.apache.org/jira/browse/SANDBOX-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13199565#comment-13199565 ]
Simone Tripodi commented on SANDBOX-382: ---------------------------------------- HI Marco, patch looks good, 2 minor observation before applying it: * {{GraphException}} is a runtime exception, so test methods shouldn't explicitly throw it; * I would suggets to create a proper layer exception that extends {{GraphException}}, just like {{PathNotFoundException}} in the shortest path algorithms. Can you modify the patch please? TIA! > Add new test for coloring > ------------------------- > > Key: SANDBOX-382 > URL: https://issues.apache.org/jira/browse/SANDBOX-382 > Project: Commons Sandbox > Issue Type: Sub-task > Components: Graph > Reporter: Marco Speranza > Attachments: SANDBOX-382_AddedColoringTestCase.patch > > > Add new test cases for backtracking and greedy algorithm: > * Test a Null graph > * test a null color list > * test an empty graph -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira