[
https://issues.apache.org/jira/browse/MATH-741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13205427#comment-13205427
]
Gilles commented on MATH-741:
-----------------------------
Leandro,
First, I must say that we are really happy that you want to join in and
contribute.
However, your proposal and implementations have several issues:
* The formatting is not compliant.
* The documentation is incomplete and contains a lot of typos.
* The purpose of the proposal is not clear and should be presented on the "dev"
ML. (For example, the name "UnivariateFunctionFactory" does not reflect the
specific concept at hand.)
* The implementation uses the type of coding that is best avoided whenever
possible (cf "setResult" and "initUnivariateFunctionFactory").
Please note that I couldn't review your code in much detail, because the main
priority is to release 3.0 very soon now.
But you should really start a discussion on this feature on the "dev" ML.
Thanks.
> Univariate Function Series Abstract Factory Implementation
> ----------------------------------------------------------
>
> Key: MATH-741
> URL: https://issues.apache.org/jira/browse/MATH-741
> Project: Commons Math
> Issue Type: New Feature
> Affects Versions: 4.0
> Reporter: Leandro Ariel Pezzente
> Priority: Minor
> Attachments: Hypergeometric.java, TestHypergeometric.java,
> UnivariateFunctionFactory.java
>
>
> To Implement an abstract class for witch Univariate functions constructed
> using functional series. This abstract class must resolve all terms sums
> using recursive iterative methods. Classes subclassed by this abstract
> function must implement UnivariateFunction interface.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
