[ https://issues.apache.org/jira/browse/MATH-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221466#comment-13221466 ]
Gilles commented on MATH-758: ----------------------------- Class "AbstractLeastSquaresOptimizer" in package "optimization.general" uses many protected instance variables which are modified in subclasses. This cannot be changed at this point (too many things to touch and a quite likely performance loss due to array copying). > Fields which could be private and/or final > ------------------------------------------ > > Key: MATH-758 > URL: https://issues.apache.org/jira/browse/MATH-758 > Project: Commons Math > Issue Type: Bug > Reporter: Sebb > > BaseAbstractUnivariateIntegrator has several fields that are not currently > changed after construction and could be final: > protected double absoluteAccuracy; > protected double relativeAccuracy; > protected int minimalIterationCount; > protected Incrementor iterations; > protected Incrementor evaluations; > These all have getters as well, so could also be made private. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira