[ 
https://issues.apache.org/jira/browse/CODEC-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223729#comment-13223729
 ] 

Thomas Neidhart edited comment on CODEC-132 at 3/6/12 10:35 PM:
----------------------------------------------------------------

Hi,

please find attached a patch for the outlined solution: adding a maximum 
phoneme parameter to the engine that limits the number of phonemes processed / 
returned.

By now, I have assumed a default of 20, if the user does not provide a value 
himself. Would like to hear some feedback from the original author on that.

Ah, testcoverage improved from 91% to 92% ;-)
                
      was (Author: tn):
    Hi,

please find attached a patch for the outlined solution: addind a maximum 
phoneme parameter to the engine that limits the number of phonemes processed / 
returned.

By now, I have assumed a default of 20, if the user does not provide a value 
himself. Would like to hear some feedback from the original author on that.

Ah, testcoverage improved from 91% to 92% ;-)
                  
> BeiderMorseEncoder OOM issues
> -----------------------------
>
>                 Key: CODEC-132
>                 URL: https://issues.apache.org/jira/browse/CODEC-132
>             Project: Commons Codec
>          Issue Type: Bug
>    Affects Versions: 1.6
>            Reporter: Robert Muir
>         Attachments: CODEC-132.patch, CODEC-132_test.patch
>
>
> In Lucene/Solr, we integrated this encoder into the latest release.
> Our tests use a variety of random strings, and we have recent jenkins failures
> from some input streams (of length <= 10), using huge amounts of memory (e.g. 
> > 64MB),
> resulting in OOM.
> I've created a test case (length is 30 here) that will OOM with -Xmx256M. 
> I haven't dug into this much as to what's causing it, but I suspect there 
> might be a bug
> revolving around certain punctuation characters: we didn't see this happening 
> until
> we beefed up our random string generation to start producing "html-like" 
> strings.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to