[
https://issues.apache.org/jira/browse/SANDBOX-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13224087#comment-13224087
]
Simone Tripodi commented on SANDBOX-352:
----------------------------------------
Nice to have the issue resolved - less nice the bunch of modifications involved.
The commit includes both the issue resolution AND a refactoring that is *not*
related to the current issue resolution - please next times split steps you
intend to perform ad *discuss first*.
Sentences like:
{code}
+ return new KosarajuSharirAlgorithm<V, E, G>( graph
).applyingKosarajuSharir( source );
+ return new CheriyanMehlhornGabowAlgorithm<V, E, G>( graph
).applyingCheriyanMehlhornGabow();
+ return new TarjanAlgorithm<V, E, G>( graph ).applyingTarjan();
{code}
why you have to explicitly call the method with the same name? It is a little
redundant, check [r1297872|http://svn.apache.org/viewvc?rev=1297872&view=rev]
out to see if you agree how I propose modifying the signatures.
As a side note: {{System.out.println}} should be removed, discuss on {{dev@}}
to add a logger if needed.
> Provide Cheriyan-Mehlhorn/Gabow's strongly connected component algorithm
> implementation
> ---------------------------------------------------------------------------------------
>
> Key: SANDBOX-352
> URL: https://issues.apache.org/jira/browse/SANDBOX-352
> Project: Commons Sandbox
> Issue Type: Sub-task
> Reporter: Simone Tripodi
> Assignee: Marco Speranza
>
> The {{CheriyanMehlhornGabow}} class contains and empty
> [Cheriyan-Mehlhorn/Gabow|http://en.wikipedia.org/wiki/Cheriyan%E2%80%93Mehlhorn/Gabow_algorithm]'s
> algorithm implementation that has to be filled
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
