[ 
https://issues.apache.org/jira/browse/MATH-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250490#comment-13250490
 ] 

Thomas Neidhart commented on MATH-775:
--------------------------------------

hmm, I see your point. My concern was that there is already a public 
getChromosomes method that I have now changed to return an unmodifiable version 
of the internal list. As derived classes need access to the internal list (to 
alter it), I added a protected getChromosomeList method, but somehow this did 
not feel right.

Maybe a different name for the method would suffice?
                
> In the ListPopulation constructor, the check for a negative populationLimit 
> should occur first.
> -----------------------------------------------------------------------------------------------
>
>                 Key: MATH-775
>                 URL: https://issues.apache.org/jira/browse/MATH-775
>             Project: Commons Math
>          Issue Type: Bug
>    Affects Versions: 3.0
>            Reporter: Reid Hochstedler
>              Labels: genetics
>             Fix For: 3.1
>
>         Attachments: MATH-775.txt
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> In the ListPopulation constructor, the check to see whether the 
> populationLimit is positive should occur before the check to see if the 
> number of chromosomes is greater than the populationLimit.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to