[
https://issues.apache.org/jira/browse/MATH-782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259642#comment-13259642
]
Luc Maisonobe commented on MATH-782:
------------------------------------
I have no specific comment about this fix, just a question.
The previous implementation, check user case after an if/else structure, so it
was checked each time. Now it is checked only in one branch. Are we sure we
would not always end up in the other branch and never user user check ?
> BrentOptimizer: User-defined check block is badly placed
> --------------------------------------------------------
>
> Key: MATH-782
> URL: https://issues.apache.org/jira/browse/MATH-782
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 3.0
> Reporter: Gilles
> Assignee: Gilles
> Fix For: 3.1
>
> Attachments: MATH-782.patch
>
>
> The CM implementation of Brent's original algorithm was supposed to allow for
> a user-defined stopping criterion (in addition to Brent's default one).
> However, it turns out that this additional block of code is not at the right
> location, implying an unwanted early exit.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
