[
https://issues.apache.org/jira/browse/IO-337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13393532#comment-13393532
]
Sebb commented on IO-337:
-------------------------
Nice idea, but this will break compatibility.
It might be possible to introduce a new class for the enum, and deprecate the
old class and methods that use it.
> ByteOrderMark can be refactored as an enum
> ------------------------------------------
>
> Key: IO-337
> URL: https://issues.apache.org/jira/browse/IO-337
> Project: Commons IO
> Issue Type: New Feature
> Reporter: Yaniv Kunda
> Priority: Minor
> Attachments: ByteOrderMark-enum.patch
>
>
> ByteOrderMark is used primarily for encapsulating the data regarding to
> Unicode BOMs. Since those are fixed, it would make sense to make it an enum,
> instead of a public class.
> I have attached a patch that only covers ByteOrderMark itself, including an
> additional getCharset() utility method, and toString() simplification.
> This patch does not cover:
> 1) Its incorrect use (per its perceived purpose) in
> XmlStreamReader.XML_GUESS_BYTES
> 2) The now-unnecessary tests
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
