[ https://issues.apache.org/jira/browse/POOL-227?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13426071#comment-13426071 ]
Liviu Tudor commented on POOL-227: ---------------------------------- Hi guys I'm really sorry, it seems to be my Eclipse which auto-formats on save. I'll review that and submit a new patch. As a side question though, is there a settings/xml somewhere for all the commons projects? The settings that I'm using currently work fine with functor but seems to obviously cause problems with pool :( Also, since we're on the subject of unit tests -- I am waiting for some feedback on POOL-228 -- not sure again if tests need changing or the logic is err'd? Could either of you shed some light into it? Cheers. > Unit test failures due to getMinIdle changes > -------------------------------------------- > > Key: POOL-227 > URL: https://issues.apache.org/jira/browse/POOL-227 > Project: Commons Pool > Issue Type: Bug > Affects Versions: 1.6 > Reporter: Liviu Tudor > Priority: Minor > Labels: junit > Fix For: 1.6.1 > > Attachments: POOL-227.patch > > Original Estimate: 1h > Remaining Estimate: 1h > > Following changes in POOL-212 to do with {{getMinIdle}} logic, the following > unit tests started failing: > * TestGenericKeyedObjectPool > * TestGenericKeyedObjectPoolFactory > * TestGenericObjectPoolFactory > As per discussion with Mark around this, the tests now need changing to > reflect the new logic. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira