[ https://issues.apache.org/jira/browse/MATH-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13462667#comment-13462667 ]
Yannick TANGUY commented on MATH-811: ------------------------------------- First I wanted to use enum, but it was simple to use an int, and the existing code already uses the XOR operator on boolean values (see in EventState.evaluateStep). {noformat} // check events occurrence if (g0Positive ^ (gb >= 0)) { [..] {noformat} Do you think it's better to re-write the criteria, with boolean values ? > Improve event detection by selecting g function slope > ----------------------------------------------------- > > Key: MATH-811 > URL: https://issues.apache.org/jira/browse/MATH-811 > Project: Commons Math > Issue Type: Improvement > Affects Versions: 3.1 > Reporter: Yannick TANGUY > Attachments: JIRA-811_slope_selection.patch, > JIRA-811_slope_selection_with_spaces.patch > > > We would like to select g function slope in CommonsMath event detection > feature. > This would improve event detection for the final user (the possibility to > ignore some events, and less computation time) and also correct a bug found > while using OREKIT (see https://www.orekit.org/forge/issues/104) in our > applications. > The modification consists in adding a method (getSlopeSelection() : int) in > EventHandler, and modifying one conditionnal in the method evaluateStep > (class EventState). > We can provide modified code and unitary tests for this feature. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira