[ 
https://issues.apache.org/jira/browse/VFS-440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13485638#comment-13485638
 ] 

Benjamin Piwowarski edited comment on VFS-440 at 10/28/12 3:03 PM:
-------------------------------------------------------------------

Running and no issues so far (apart from 1 error in running 
org.apache.commons.vfs2.provider.ram.test.RamProviderTestCase)

However, I think there might be issues (but they are not related to this patch) 
due to the fact that at least
- FileObject relies on finalize;
- getChannel() in SftpFileSystem can return channels that are not closed all 
the time

In fact, closing the Sftp server does close many dandling sessions (observed in 
the previous version of the patch). You could also use                 

    Server.stop(true);

in SftpProviderTestCase to force the server to kill all the sessions.

When I have some free time I can look at that (at least the getChannel() 
issue), but again I think this patch does not make things worse or better with 
that respect.

                
      was (Author: bpiwowar):
    Running and no issues so far.

However, I think there might be issues (but they are not related to this patch) 
due to the fact that at least
- FileObject relies on finalize;
- getChannel() in SftpFileSystem can return channels that are not closed all 
the time

In fact, closing the Sftp server does close many dandling sessions (observed in 
the previous version of the patch). You could also use                 

    Server.stop(true);

in SftpProviderTestCase to force the server to kill all the sessions.

When I have some free time I can look at that (at least the getChannel() 
issue), but again I think this patch does not make things worse or better with 
that respect.


                  
> [SFTP] Stream (e.g. netcat) proxy for Sftp file system (aka ProxyCommand)
> -------------------------------------------------------------------------
>
>                 Key: VFS-440
>                 URL: https://issues.apache.org/jira/browse/VFS-440
>             Project: Commons VFS
>          Issue Type: Improvement
>            Reporter: Benjamin Piwowarski
>            Priority: Minor
>              Labels: proxy, sftp
>         Attachments: sftp-stream-proxy.diff, sftp-stream-proxy-v2.diff, 
> sftp-stream-proxy-v3.diff, sftp-stream-proxy-v4.diff, 
> sftp-stream-proxy-v5.diff, sftp-stream-proxy-v6.diff, 
> sftp-stream-proxy-v7-bis.diff, sftp-stream-proxy-v7.diff
>
>
> What I propose is to add the possibility to connect to a remote SSH server 
> through an SSH connection stream (instead of an HTTP or SOCKS proxy). See for 
> instance
> http://backdrift.org/transparent-proxy-with-ssh
> for a use case.
> This simulates a ProxyCommand where the command is run on a SSH host.
> The patch also contains a test for the new functionality. 
> Example of use (with the netcat command nc -q 0 HOSTNAME PORT)
> {code:java}
> builder.setProxyType(opts, SftpFileSystemConfigBuilder.PROXY_STREAM);
> builder.setProxyCommand(opts, SftpStreamProxy.NETCAT_COMMAND);
> builder.setProxyHost(opts, "gate.way.host");
> builder.setProxyPort(opts, 22);
> builder.setProxyOptions(opts, proxyOptions);
> {code}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to