[ https://issues.apache.org/jira/browse/LANG-856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13496187#comment-13496187 ]
Sebb commented on LANG-856: --------------------------- Thanks for the patch; however had to replace tabs with spaces. We don't use tabs in Commons code. URL: http://svn.apache.org/viewvc?rev=1408713&view=rev Log: LANG-856 Code refactoring in NumberUtils Modified: commons/proper/lang/trunk/src/changes/changes.xml commons/proper/lang/trunk/src/main/java/org/apache/commons/lang3/math/NumberUtils.java > Code refactoring in NumberUtils > ------------------------------- > > Key: LANG-856 > URL: https://issues.apache.org/jira/browse/LANG-856 > Project: Commons Lang > Issue Type: Improvement > Components: lang.math.* > Reporter: nguyen phuc lam > Priority: Minor > Fix For: 3.2 > > Attachments: NumberUtils.diff > > > NumberUtils contains some redundant pieces of code which are doing the same > validation on the array parameter. This validation should be extracted to a > method which will be called by other methods in this class. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira