[
https://issues.apache.org/jira/browse/CSV-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499486#comment-13499486
]
Gary Gregory commented on CSV-68:
---------------------------------
"I did't add brackets in all if branches, to keep the code short. This may
cause checkstyle errors."
I changed the patch to match the component's format
"The header array is now copied in the CSVFormat constructor."
I simplified the code by cloning the array.
"How ever, the reference to the header array can still escape the
CSVFormatBuilder. This may cause issues if CSVFormatBuilder instances are
shared between multiple threads. Do you think this is an issue that has to be
addressed?"
Well... the CSVFormat class claims to be immutable, which it is thanks to the
header array fix.
CSVFormatBuilder is not immutable by its nature. Do you foresee a case where
the header passed to a builder who be modified by before the format is built?
It would seem odd.
> Use the Builder pattern for CSVFormat
> -------------------------------------
>
> Key: CSV-68
> URL: https://issues.apache.org/jira/browse/CSV-68
> Project: Commons CSV
> Issue Type: Improvement
> Reporter: Sebb
> Fix For: 1.0
>
> Attachments: CSV-68_20121111.patch, CSV-68_20121114.patch,
> CSV-68_20121115.patch, CSV-68_20121117.patch, CSV-68.patch, CSVFormat2.java,
> CVSFormat2Main.java
>
>
> Using a builder pattern to create CSVFormat instances would allow the
> settings to be validated at creation time and would eliminate the need to
> keep creating new CSVFormat instances whilst still allowing the class to be
> immutable.
> A possible API is as follows:
> {code}
> CSVFormat DEFAULT = CSVFormat.init(',') // delimiter is required
> .withEncapsulator('"')
> .withLeadingSpacesIgnored(true)
> .withTrailingSpacesIgnored(true)
> .withEmptyLinesIgnored(true)
> .withLineSeparator("\r\n") // optional, as it would be the default
> .build();
> CSVFormat format = CSVFormat.init(CSVFormat.DEFAULT) // alternatively start
> with pre-defined format
> .withSurroundingSpacesIgnored(false)
> .build();
> {code}
> Compare this with the current syntax:
> {code}
> // internal syntax; not easy to determine what all the parameters do
> CSVFormat DEFAULT1 = new CSVFormat(',', '"', DISABLED, DISABLED, true, true,
> false, true, CRLF);
> // external syntax
> CSVFormat format = CSVFormat.DEFAULT.withSurroundingSpacesIgnored(false);
> {code}
> As a proof of concept I've written skeleton code which compiles (but needs
> completing).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
