[
https://issues.apache.org/jira/browse/VFS-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13588115#comment-13588115
]
Jean-Marc Borer edited comment on VFS-428 at 2/27/13 8:23 AM:
--------------------------------------------------------------
I've found a solution for the trailing slashes that seems to work not too
badly: in the HttpFileObject's setupMethod, I add a trailing slash to the
requset path when VFS.isUriStyle is false and the file type is supposed to be a
folder.
protected void setupMethod(final HttpMethod method) throws
FileSystemException, URIException
{
String pathEncoded = ((URLFileName)
getName()).getPathQueryEncoded(urlCharset);
if (!VFS.isUriStyle()
&& (getName().getType() == FileType.FOLDER)
&& !pathEncoded.endsWith("/") ) {
pathEncoded = pathEncoded + "/";
}
method.setPath(pathEncoded);
method.setFollowRedirects(true);
method.setRequestHeader("User-Agent", "Jakarta-Commons-VFS");
}
This seems to work not too badly (at least with my unit tests), but it is
required that that the file that is resolved in the first place ends with a
trailing slash:
FileObject fo =
VFS.getManager().resolveFile("http://localhost:8080/dav/conf/test/";);
I did not provide a patch yet, because I integrated this fix in my own code
which is a fork of VFS 2.0. It is taking too much time to integrate those
patches into VFS trunk and get a new release of the lib. Can't wait until that,
but I will try to port the patch to trunk when I have some time.
was (Author: jmborer):
I've found a solution for the trailing slashes that seems to work not too
badly: in the HttpFileObject's setupMethod, I add a trailing slash to the
requset path when VFS.isUriStyle is false and the file type is supposed to be a
folder.
protected void setupMethod(final HttpMethod method) throws
FileSystemException, URIException
{
String pathEncoded = ((URLFileName)
getName()).getPathQueryEncoded(urlCharset);
if (!VFS.isUriStyle()
&& (getName().getType() == FileType.FOLDER)
&& !pathEncoded.endsWith("/") ) {
pathEncoded = pathEncoded + "/";
}
method.setPath(pathEncoded);
method.setFollowRedirects(true);
method.setRequestHeader("User-Agent", "Jakarta-Commons-VFS");
}
This seems to work not too badly (at least with my unit tests), but it is
required that that the file that is resolved in the first place ends with a
trailing slash:
FileObject fo =
VFS.getManager().resolveFile("http://localhost:8080/dav/conf/test/";);
> DavException: (301) Moved Permanently
> --------------------------------------
>
> Key: VFS-428
> URL: https://issues.apache.org/jira/browse/VFS-428
> Project: Commons VFS
> Issue Type: Bug
> Affects Versions: 2.0, 2.1
> Environment: Apache 2.2.22 as Testerver and setted up like
> http://commons.apache.org/vfs/testserver.html (but changed the 'crypt'
> password)
> Reporter: Robert Kornmesser
> Priority: Blocker
> Labels: webdav
>
> Running the WebdavProviderTestCase using mvn -P webdav clean test
> -Dtest.webdav.uri=webdav://vfsusr:vfstest@localhost/vfstest
> -Dtest=WebdavProviderTestCase results in
> {code}DavException: (301) Moved Permanently
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.645 sec <<<
> FAILURE!
> Results :
> Tests in error:
>
> junit.framework.TestSuite@55c9be00(org.apache.commons.vfs2.provider.webdav.test.WebdavProviderTestCase$1):
> Could not determine the type of file
> "webdav://vfsusr:****@localhost/vfstest/read-tests".
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0
> {code}
> The deeper Problem is, that the HttpClient using by VFS does not append a
> trailing slash and mod_dir of httpd has "DirectorySlash On" per default. So
> httpd send 301 redirect to the same url with / appended.
> I know that for this reason of problematic webdav client apache introduced
> "redirect-carefully" for some user agents using the "BrowserMatch" directive.
> So I just tried adding the following into my <Directory> directive
> {code}
> BrowserMatch "^Jakarta-Commons-VFS" redirect-carefully
> BrowserMatch "^Jakarta Commons-HttpClient/3.0" redirect-carefully
> BrowserMatch "^Jakarta Commons-HttpClient/3.1" redirect-carefully
> {code}
> Its needed to have Jakarta-Commons-VFS *and* Jakarta Commons-HttpClient
> because of two requests from commons vfs using two different user agents.
> But instead of solving the issue, I get for every FileObject.getChildren()
> call at least one FileObject of type imaginary with the same basename as the
> parent. Thats not a problem at all (besides that this is totally wrong!) but
> deleting a parent just dont work anymore, because of an *non-existent*
> imaginary file inside the dir which cannot be deleted of course.
> To cut a long story short, what is the right httpd webdav server config to
> use 2.0 Release version of VFS?
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
