[ 
https://issues.apache.org/jira/browse/FILEUPLOAD-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13598673#comment-13598673
 ] 

Simone Tripodi commented on FILEUPLOAD-137:
-------------------------------------------

while it would be possible to work around the NPE on {{boundary}}, the adapted 
{{InputStream}} reference cannot be set if not via the constructor since 
{{MultipartStream#input}} is {{final}}.

Since it doesn't look like there is a fix for this, I'd go for 
{{UnsupportedOperationException}} in {{MultipartStream()}} constructor and add 
a note in its javadoc.

Thoughts?
                
> MultipartStream public API broken
> ---------------------------------
>
>                 Key: FILEUPLOAD-137
>                 URL: https://issues.apache.org/jira/browse/FILEUPLOAD-137
>             Project: Commons FileUpload
>          Issue Type: Bug
>    Affects Versions: 1.2
>            Reporter: Mark Sinke
>            Assignee: Jochen Wiedmann
>             Fix For: 1.2.1
>
>
> In commons-transaction 1.2 the MultipartStream class has 2 public 
> constructors. Both are deprecated; however their implementation delegates to 
> non-visible (package-private) constructors. There are two issues here:
> 1. the deprecated, delegating constructors use a null pointer for the 
> progress notifier, which in turn yield a NullPointerException when you try to 
> use them
> 2. the non-deprecated constructors are not visible.
> Hence, I cannot really upgrade from 1.0 to 1.2.
> Thanks,
> Mark.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to