[
https://issues.apache.org/jira/browse/CHAIN-94?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13692236#comment-13692236
]
Benedikt Ritter commented on CHAIN-94:
--------------------------------------
Hello Jonas,
first of all thanks for your patch! I can nearly apply it as you uploaded it,
but there are some points that need fixing :)
* The patch contains tab characters. Please make sure patches do not contain
any tab characters. I'd suggest to review the patch file with an editor of your
choice which is capable of displaying white space characters.
* Where does {{readOnlyRemainsUnchangedAfterCallingTwice()}} come from? It
hasn't been in the old test and to be honest it doesn't make much sense to me
:) You wouldn't test if {{java.util.Map.get(Object)}} returns the same value if
called twice, would you?
* {{contextProvidesReadWriteProperty()}} is unnecessary,
{{readWritePropertyIsAString}} already makes sure that
{{context.get("readWrite")}} is not null (because null is not instanceof
String).
* Where have all the write only property related tests gone?
If you could fix this, I'd happily apply your patch.
TIA!
Benedikt
> Refactor tests in class TestContextTestCase
> -------------------------------------------
>
> Key: CHAIN-94
> URL: https://issues.apache.org/jira/browse/CHAIN-94
> Project: Commons Chain
> Issue Type: Test
> Affects Versions: 2.0
> Reporter: Jonas Sprenger
> Priority: Trivial
> Labels: patch
> Fix For: 2.0
>
> Attachments: chain-94.patch
>
>
> Refactor tests to increase readability and remove unnecessary assertions.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
