[ 
https://issues.apache.org/jira/browse/COLLECTIONS-474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13692257#comment-13692257
 ] 

Sebb commented on COLLECTIONS-474:
----------------------------------

Looks like a bug to me, because the size() is 2 just before the putAll().

The problem is that the code assumes that the put method will only return null 
if the key was not replaced; however that is only true if the original value 
was not null. For maps that allow null, the return value of put cannot be used 
to determine if the key was replaced.
                
> Exception in ListOrderedMap
> ---------------------------
>
>                 Key: COLLECTIONS-474
>                 URL: https://issues.apache.org/jira/browse/COLLECTIONS-474
>             Project: Commons Collections
>          Issue Type: Bug
>          Components: Map
>    Affects Versions: 4.0
>         Environment: java 1.7.0_09
>            Reporter: Ning Chen
>         Attachments: Test.java
>
>
> Dear apache developers, thanks for the great project. Recently, I encountered 
> an IndexOutOfBoundsException in ListOrderedMap in the latest revision 
> (r1495998) with the crash stack trace: 
> Exception in thread "main" java.lang.IndexOutOfBoundsException: Index: 2, 
> Size: 1
>       at java.util.ArrayList.add(ArrayList.java:367)
>       at 
> org.apache.commons.collections4.map.ListOrderedMap.put(ListOrderedMap.java:448)
>       at 
> org.apache.commons.collections4.map.ListOrderedMap.putAll(ListOrderedMap.java:246)
>       at Test.main(Test.java:15)
> I've also attached a test case that can reproduce this crash.
> I think this test case actually reveals the bug reported in COLLECTIONS-411 
> (https://issues.apache.org/jira/browse/COLLECTIONS-411). However, it seems 
> that the original patch for COLLECTIONS-411 missed a corner case.
> Could you please check if this is indeed a bug? Thanks!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to