[ 
https://issues.apache.org/jira/browse/MATH-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13701599#comment-13701599
 ] 

Phil Steitz commented on MATH-1000:
-----------------------------------

Might be better to better to return a List or an array, as elements are ordered 
by the Comparator and I think TreeMap#values will give them to you in ascending 
order (so no need to sort).  Returning a List or array may make it a little 
easier for users to work with / document APIs built using this method.

Also, the commented out code makes no sense to me.  Should probably be removed 
before commit.

Thanks for doing this.
                
> Add mode function to Frequency class
> ------------------------------------
>
>                 Key: MATH-1000
>                 URL: https://issues.apache.org/jira/browse/MATH-1000
>             Project: Commons Math
>          Issue Type: New Feature
>            Reporter: Sebb
>         Attachments: MATH-1000.patch, MATH-1000-Test.patch
>
>
> It would be useful to have a mode function for the Frequency class

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to