[ https://issues.apache.org/jira/browse/MATH-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13794846#comment-13794846 ]
Phil Steitz commented on MATH-1039: ----------------------------------- This looks very good and useful. Thanks for the patch! Just a couple of quick comments and I can commit. 1. For 3.3 we can't add to the interfaces, so I suggest to add impls to the abstract parents and hold the add to the interfaces until 4.0. Unless someone screams, I will do that (so just omit the changes to the distribution interfaces) 2. Thanks so much for the careful job on the test cases. Where does the reference data come from? I like to include the source of reference data where possible. > Logarithmic probability and density calculations for the distributions > ---------------------------------------------------------------------- > > Key: MATH-1039 > URL: https://issues.apache.org/jira/browse/MATH-1039 > Project: Commons Math > Issue Type: New Feature > Reporter: Aleksei Dievskii > Priority: Minor > Labels: features, patch > Attachments: LOGDENSITY.patch > > > A person working with fairly small probabilities and densities often employs > their logarithms to increase precision and decrease the chance of an > underflow. However, just taking a log of the probability() or density() > return value doesn't necessary solve the problem, as these methods themselves > could have lost precision or underflowed. This patch introduces new > logProbability() and logDensity() methods overriden for many relevant > distribution. The patch also introduces tests of these new methods. -- This message was sent by Atlassian JIRA (v6.1#6144)