[
https://issues.apache.org/jira/browse/MATH-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796597#comment-13796597
]
Sean Owen commented on MATH-1041:
---------------------------------
OK. This had felt like so minor as to be one issue to me, but I can see
breaking it into two.
But here I meant that within one issue you had me invite discussion to iterate
on the patch but had twice committed part of it before those changes completed.
Truly no big deal, but I figured it would just save you trouble to converge on
the right patch and then commit. (I still have some extra tests outstanding on
the 'patch' side FWIW.)
You are welcome to commit any variation on the proposed changed here that you
see fit. Thanks Gilles, don't let me burn any more of your cycles.
> Add Pair factory method, toString(), Comparator
> ------------------------------------------------
>
> Key: MATH-1041
> URL: https://issues.apache.org/jira/browse/MATH-1041
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 3.2
> Reporter: Sean Owen
> Priority: Minor
> Labels: comparator, pair
> Attachments: MATH-1041_Comparator.patch, MATH-1041_Pair.patch
>
>
> I use Commons Math heavily, and have adopted its Pair class for the cases
> where I need, well, a pair of things.
> The attached patch adds three small improvements to the Pair class:
> - toString() method
> - factory method ".create()" to avoid duplicating generic types on instance
> creation
> - a Comparator
> Tests are included. I won't feel offended if this is rejected or modified but
> just wanted to supply the suggestion.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
