[ 
https://issues.apache.org/jira/browse/SCXML-171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13796695#comment-13796695
 ] 

Woonsan Ko commented on SCXML-171:
----------------------------------

Hi Rahul,

Thanks for the suggestion. I tried it with the option, but it fails, too.
It succeeds with the following option instead:
{code}
@FixMethodOrder(MethodSorters.JVM)
public class CustomActionTest {
{code}

However, as pointed out in its javadoc [1], the MethodSorters.JVM option may 
give inconsistent results in different JVMs.
So, I think I should increase the expected execution count on Hello action in 
the test class and verify if the expected execution count is the same as the 
count internally stored in the Hello static member. I think that's what 
CustomActionTest#testCustomActionCallbacks() wanted to achieve.
I'll commit it today. Please take a review. Thanks in advance!

Cheers,

Woonsan

[1] http://junit.czweb.org/apidocs/org/junit/runners/MethodSorters.html#JVM

> Upgrade JUnit dependency to 4.11
> --------------------------------
>
>                 Key: SCXML-171
>                 URL: https://issues.apache.org/jira/browse/SCXML-171
>             Project: Commons SCXML
>          Issue Type: Task
>    Affects Versions: 2.0
>            Reporter: Woonsan Ko
>            Assignee: Woonsan Ko
>             Fix For: 2.0
>
>
> Better update to JUnit 4.11; Would be nicer for new comers.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to