[ 
https://issues.apache.org/jira/browse/IMAGING-109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Damjan Jovanovic resolved IMAGING-109.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.0

Thank you for your bug report. Patch committed, resolving fixed.

> Several files contain non-UTF8 characters
> -----------------------------------------
>
>                 Key: IMAGING-109
>                 URL: https://issues.apache.org/jira/browse/IMAGING-109
>             Project: Commons Imaging
>          Issue Type: Bug
>            Reporter: Max Gilead
>            Priority: Minor
>             Fix For: 1.0
>
>
> That makes javac very unhappy, particularly version 7 on OSX.
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:32: 
> error: unmappable character for encoding UTF8
>         double var_X = X / ref_X; // ref_X = 95.047 Observer= 2�, Illuminant=
>                                                                ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:84: 
> error: unmappable character for encoding UTF8
>         final double X = ref_X * var_X; // ref_X = 95.047 Observer= 2�, 
> Illuminant=
>                                                                      ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:127: 
> error: unmappable character for encoding UTF8
>         // Observer = 2�, Illuminant = D65
>                        ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:128: 
> error: unmappable character for encoding UTF8
>         final double var_X = X / 100.0; // Where X = 0 � 95.047
>                                                        ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:129: 
> error: unmappable character for encoding UTF8
>         final double var_Y = Y / 100.0; // Where Y = 0 � 100.000
>                                                        ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:130: 
> error: unmappable character for encoding UTF8
>         final double var_Z = Z / 100.0; // Where Z = 0 � 108.883
>                                                        ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:164: 
> error: unmappable character for encoding UTF8
>         double var_R = r / 255.0; // Where R = 0 � 255
>                                                  ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:165: 
> error: unmappable character for encoding UTF8
>         double var_G = g / 255.0; // Where G = 0 � 255
>                                                  ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:166: 
> error: unmappable character for encoding UTF8
>         double var_B = b / 255.0; // Where B = 0 � 255
>                                                  ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:188: 
> error: unmappable character for encoding UTF8
>         // Observer. = 2�, Illuminant = D65
>                         ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:201: 
> error: unmappable character for encoding UTF8
>         // RGB values = 0 � 255
>                           ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:202: 
> error: unmappable character for encoding UTF8
>         // CMY values = 0 � 1
>                           ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:218: 
> error: unmappable character for encoding UTF8
>         // CMY values = 0 � 1
>                           ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:219: 
> error: unmappable character for encoding UTF8
>         // RGB values = 0 � 255
>                           ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:229: 
> error: unmappable character for encoding UTF8
>         // Where CMYK and CMY values = 0 � 1
>                                          ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:264: 
> error: unmappable character for encoding UTF8
>         // Where CMYK and CMY values = 0 � 1
>                                          ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:290: 
> error: unmappable character for encoding UTF8
>         final double var_R = (R / 255.0); // Where RGB values = 0 � 255
>                                                                   ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:317: 
> error: unmappable character for encoding UTF8
>             H = 0; // HSL results = 0 � 1
>                                       ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:367: 
> error: unmappable character for encoding UTF8
>             // HSL values = 0 � 1
>                               ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:368: 
> error: unmappable character for encoding UTF8
>             R = L * 255; // RGB results = 0 � 255
>                                             ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:414: 
> error: unmappable character for encoding UTF8
>         final double var_R = (R / 255.0); // RGB values = 0 � 255
>                                                             ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:439: 
> error: unmappable character for encoding UTF8
>             H = 0; // HSV results = 0 � 1
>                                       ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:476: 
> error: unmappable character for encoding UTF8
>             // HSV values = 0 � 1
>                               ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:518: 
> error: unmappable character for encoding UTF8
>             R = var_r * 255; // RGB results = 0 � 255
>                                                 ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:578: 
> error: unmappable character for encoding UTF8
>             X = ref_X * var_X; // ref_X = 95.047 Observer= 2�, Illuminant= D65
>                                                             ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:670: 
> error: unmappable character for encoding UTF8
>         // Where CIE-H� = 0 � 360�
>                       ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:670: 
> error: unmappable character for encoding UTF8
>         // Where CIE-H� = 0 � 360�
>                             ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:670: 
> error: unmappable character for encoding UTF8
>         // Where CIE-H� = 0 � 360�
>                                  ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:709: 
> error: unmappable character for encoding UTF8
>         final double ref_X = 95.047; // Observer= 2�, Illuminant= D65
>                                                    ^
> src/main/java/org/apache/commons/imaging/color/ColorConversions.java:742: 
> error: unmappable character for encoding UTF8
>         final double ref_X = 95.047; // Observer= 2�, Illuminant= D65
>                                                    ^
> src/main/java/org/apache/commons/imaging/formats/bmp/BmpHeaderInfo.java:20: 
> error: unmappable character for encoding UTF8
>     // �BM� - Windows 3.1x, 95, NT, �
>        ^
> src/main/java/org/apache/commons/imaging/formats/bmp/BmpHeaderInfo.java:20: 
> error: unmappable character for encoding UTF8
>     // �BM� - Windows 3.1x, 95, NT, �
>           ^
> src/main/java/org/apache/commons/imaging/formats/bmp/BmpHeaderInfo.java:20: 
> error: unmappable character for encoding UTF8
>     // �BM� - Windows 3.1x, 95, NT, �
>                                     ^
> src/main/java/org/apache/commons/imaging/formats/bmp/BmpHeaderInfo.java:21: 
> error: unmappable character for encoding UTF8
>     // �BA� - OS/2 Bitmap Array
>        ^
> src/main/java/org/apache/commons/imaging/formats/bmp/BmpHeaderInfo.java:21: 
> error: unmappable character for encoding UTF8
>     // �BA� - OS/2 Bitmap Array
>           ^
> src/main/java/org/apache/commons/imaging/formats/bmp/BmpHeaderInfo.java:22: 
> error: unmappable character for encoding UTF8
>     // �CI� - OS/2 Color Icon�
>        ^
> src/main/java/org/apache/commons/imaging/formats/bmp/BmpHeaderInfo.java:22: 
> error: unmappable character for encoding UTF8
>     // �CI� - OS/2 Color Icon�
>           ^
> src/main/java/org/apache/commons/imaging/formats/bmp/BmpHeaderInfo.java:22: 
> error: unmappable character for encoding UTF8
>     // �CI� - OS/2 Color Icon�
>                              ^
> src/main/java/org/apache/commons/imaging/formats/bmp/BmpHeaderInfo.java:23: 
> error: unmappable character for encoding UTF8
>     // CP� - OS/2 Color Pointer
>          ^
> src/main/java/org/apache/commons/imaging/formats/bmp/BmpHeaderInfo.java:24: 
> error: unmappable character for encoding UTF8
>     // �IC� - OS/2 Icon
>        ^
> src/main/java/org/apache/commons/imaging/formats/bmp/BmpHeaderInfo.java:24: 
> error: unmappable character for encoding UTF8
>     // �IC� - OS/2 Icon
>           ^
> src/main/java/org/apache/commons/imaging/formats/bmp/BmpHeaderInfo.java:25: 
> error: unmappable character for encoding UTF8
>     // �PT� - OS/2 Pointer
>        ^
> src/main/java/org/apache/commons/imaging/formats/bmp/BmpHeaderInfo.java:25: 
> error: unmappable character for encoding UTF8
>     // �PT� - OS/2 Pointer
>           ^
> src/main/java/org/apache/commons/imaging/formats/jpeg/decoder/Dct.java:36: 
> error: unmappable character for encoding UTF8
>      * do 100 million IDCTs (less is better): Rene' St�ckel's Feig, int: 45.07
>                                                       ^
> src/main/java/org/apache/commons/imaging/formats/psd/PsdConstants.java:151: 
> error: unmappable character for encoding UTF8
>                             "Document specific IDs, layer IDs will be 
> generated starting at this base value or a greater value if we find existing 
> IDs to already exceed it. It�s purpose is to avoid the case where we add 
> layers, flatten, save, open, and then add more layers that end up with the 
> same IDs as the first set. 4 bytes."),
>                                                                               
>                                                                               
>                    ^
> src/main/java/org/apache/commons/imaging/formats/psd/PsdConstants.java:169: 
> error: unmappable character for encoding UTF8
>                             "Jump To XPEP. 2 bytes major version, 2 bytes 
> minor version, 4 bytes count. Following is repeated for count: 4 bytes block 
> size, 4 bytes key, if key = 'jtDd' then next is a Boolean for the dirty flag 
> otherwise it�s a 4 byte entry for the mod date."),
>                                                                               
>                                                                               
>                                                                               
>       ^
> src/main/java/org/apache/commons/imaging/formats/tiff/photometricinterpreters/PhotometricInterpreterLogLuv.java:86:
>  error: unmappable character for encoding UTF8
>             X = ref_X * var_X; // ref_X = 95.047 Observer= 2�, Illuminant= D65
>                                                             ^
> src/main/java/org/apache/commons/imaging/formats/tiff/photometricinterpreters/PhotometricInterpreterLogLuv.java:92:
>  error: unmappable character for encoding UTF8
>         // ref_X = 95.047 //Observer = 2�, Illuminant = D65
>                                         ^
> src/main/java/org/apache/commons/imaging/icc/IccTagTypes.java:28: error: 
> unmappable character for encoding UTF8
>     //    "�A2B0� (41324230h)",
>            ^
> src/main/java/org/apache/commons/imaging/icc/IccTagTypes.java:28: error: 
> unmappable character for encoding UTF8
>     //    "�A2B0� (41324230h)",
>                 ^
> src/main/java/org/apache/commons/imaging/icc/IccTagTypes.java:76: error: 
> unmappable character for encoding UTF8
>     //    "Profile calibration date and time. Initially, this tag matches the 
> contents of the profile header�s creation",
>                                                                               
>                               ^
> src/main/java/org/apache/commons/imaging/icc/IccTagTypes.java:77: error: 
> unmappable character for encoding UTF8
>     //    "date/time field. This allows applications and utilities to verify 
> if this profile matches a vendor�s profile and",
>                                                                               
>                                ^
> src/main/java/org/apache/commons/imaging/icc/IccTagTypes.java:127: error: 
> unmappable character for encoding UTF8
>     //    "2) Adjustment of the cone response values for an observer�s 
> chromatic adaptation.",
>                                                                     ^
> src/main/java/org/apache/commons/imaging/icc/IccTagTypes.java:169: error: 
> unmappable character for encoding UTF8
>     //    "PCS color is in-gamut. If the output is non-zero, the PCS color is 
> out-of-gamut, with the output value �n+1�",
>                                                                               
>                                     ^
> src/main/java/org/apache/commons/imaging/icc/IccTagTypes.java:169: error: 
> unmappable character for encoding UTF8
>     //    "PCS color is in-gamut. If the output is non-zero, the PCS color is 
> out-of-gamut, with the output value �n+1�",
>                                                                               
>                                         ^
> src/main/java/org/apache/commons/imaging/icc/IccTagTypes.java:170: error: 
> unmappable character for encoding UTF8
>     //    "being at least as far out of gamut as the output value �n�.",
>                                                                   ^
> src/main/java/org/apache/commons/imaging/icc/IccTagTypes.java:170: error: 
> unmappable character for encoding UTF8
>     //    "being at least as far out of gamut as the output value �n�.",
>                                                                     ^
> src/main/java/org/apache/commons/imaging/icc/IccTagTypes.java:237: error: 
> unmappable character for encoding UTF8
>     //    "NOTE The user�s attention is called to the possibility that the 
> use of this tag for device calibration may",
>                         ^
> 58 errors



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to