[ https://issues.apache.org/jira/browse/LANG-637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13854469#comment-13854469 ]
Matt Benson commented on LANG-637: ---------------------------------- Hi, Duncan. After more than a year, I have now reviewed this. I personally would like to see DiffList implement List<Diff<?>>, and then I would personally be in favor of committing this code. As long as it has been, I can understand if you've moved on and don't have time to make this change, in which case I can do it. > There should be a DifferenceBuilder with a ReflectionDifferenceBuilder > implementation > ------------------------------------------------------------------------------------- > > Key: LANG-637 > URL: https://issues.apache.org/jira/browse/LANG-637 > Project: Commons Lang > Issue Type: Improvement > Components: lang.builder.* > Reporter: Eric Lewis > Priority: Minor > Fix For: Review Patch > > Attachments: Diff.java, DiffBuilder.java, DiffBuilderTest.java, > DiffList.java, DiffListTest.java, DiffTest.java, Diffable.java, > commons-lang3-LANG-637-complete.patch, commons-lang3-LANG-637.patch > > > The ToStringBuilder and ReflectionToStringBuilder are great tools for > everyday development. > We use them to show all the properties in an object, which comes handy > especially for testing. > However, JUnit with its assertEquals() just outputs the toString() of the two > compared objects. For complex objects, this becomes unreadable. > So, it would be great to have a DifferenceBuilder with a > ReflectionDifferenceBuilder implementation to be able to get only the > differing properties of two objects. The question is whether the two objects > would have to be of the same type or not. -- This message was sent by Atlassian JIRA (v6.1.4#6159)