[
https://issues.apache.org/jira/browse/DBCP-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Thomas resolved DBCP-317.
------------------------------
Resolution: Fixed
This issue has the same root cause as DBCP-358. Fixing that issue has also
resolved these FindBugs warnings.
> Findbugs: Class doesn't override equals in superclass
> -----------------------------------------------------
>
> Key: DBCP-317
> URL: https://issues.apache.org/jira/browse/DBCP-317
> Project: Commons Dbcp
> Issue Type: Bug
> Affects Versions: 1.4
> Reporter: Sebb
> Priority: Minor
> Fix For: 2.0
>
>
> Findbugs: Class doesn't override equals in superclass - 8 instances
> "This class extends a class that defines an equals method and adds fields,
> but doesn't define an equals method itself. Thus, equality on instances of
> this class will ignore the identity of the subclass and the added fields. Be
> sure this is what is intended, and that you don't need to override the equals
> method. Even if you don't need to override the equals method, consider
> overriding it anyway to document the fact that the equals method for the
> subclass just return the result of invoking super.equals(o). "
> Classes (superclass) are:
> cpdsadapter.ConnectionImpl doesn't override DelegatingConnection.equals
> datasources.LRUMap doesn't override SequencedHashMap.equals
> managed.ManagedConnection doesn't override DelegatingConnection.equals
> managed.PoolableManagedConnection doesn't override
> DelegatingConnection.equals
> PoolableCallableStatement doesn't override DelegatingCallableStatement.equals
> PoolableConnection doesn't override DelegatingConnection.equals
> PoolablePreparedStatement doesn't override DelegatingPreparedStatement.equals
> PoolingConnection doesn't override DelegatingConnection.equals
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
