[
https://issues.apache.org/jira/browse/LANG-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14107946#comment-14107946
]
Benedikt Ritter commented on LANG-965:
--------------------------------------
Hello [~andd],
your patch looks promising. However there are some things I don't understand :)
* Restoring accessibility in {{readField(Object, String, boolean)}} and
{{writeField(Object, String, Object, boolean)}} looks redundant to me, since
those methods delegate to the other read/writeField methods, which already
handle the accessibility.
* I don't understand the changes in the tests you made. The tests should be
changed to verify that the accessibility of a field been read or written is the
same as before, but instead you call {{setAccessible(true)}} serveral times.
Can you elaborate why?
TIA!
Benedikt
> FieldUtils methods leak accessible flags
> ----------------------------------------
>
> Key: LANG-965
> URL: https://issues.apache.org/jira/browse/LANG-965
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.reflect.*
> Affects Versions: 3.1, 3.2.1
> Environment: Apache Maven 3.1.1
> (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17 11:22:22-0400)
> Maven home: C:\Java\apache-maven-3.1.1\bin\..
> Java version: 1.7.0_51, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_51\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> Reporter: Gary Gregory
> Assignee: Benedikt Ritter
> Fix For: Review Patch
>
> Attachments: commons-lang-965.patch
>
>
> When various FieldUtils methods are called the accessible is set to true but
> never reset to false. This is side-effect should be cleaned up.
> This makes a mess of the object model which represents the class meta data.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
