[ 
https://issues.apache.org/jira/browse/BCEL-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14168401#comment-14168401
 ] 

Konstantin Kolinko commented on BCEL-180:
-----------------------------------------

> In some cases such as JDI API we have the class constant pool content only in 
> form of separate byte array.

What do you mean? Please provide some reference.

>
I think an alternative and more simple solution is to just make the existing 
ConstantPool(DataInputStream file) constructor public instead of it being 
package-visible.

This implementation of ConstantPool(byte[]) does not check that "byte[] bytes" 
were wholly read. In other words, it allows some arbitrary bytes after the pool 
data.

> Enable loading ConstantPool from a byte array
> ---------------------------------------------
>
>                 Key: BCEL-180
>                 URL: https://issues.apache.org/jira/browse/BCEL-180
>             Project: Commons BCEL
>          Issue Type: Improvement
>            Reporter: Maxim Degtyarev
>
> In some cases such as JDI API we have the class constant pool content only in 
> form of separate byte array. Currently there is no way to load constant pool 
> from byte array.
> The proposed patch add new public constructor to the 
> org.apache.bcel.classfile.ConstantPool that allow loading ConstantPool from 
> byte array representation.
> GitHub pull request: https://github.com/apache/commons-bcel/pull/1



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to