[ https://issues.apache.org/jira/browse/IMAGING-131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Damjan Jovanovic resolved IMAGING-131. -------------------------------------- Resolution: Fixed Fix Version/s: 1.0 That only affects calls to PngImageParser.getBufferedImage() directly, calls via Imaging.getBufferedImage() always create a new params when it's null. But I've fixed it anyway, resolving. > PngImageParser#getBufferedImage() doesn't respect ImageParser specification > ---------------------------------------------------------------------------- > > Key: IMAGING-131 > URL: https://issues.apache.org/jira/browse/IMAGING-131 > Project: Commons Imaging > Issue Type: Bug > Components: Format: PNG > Affects Versions: 1.0 > Reporter: fasar > Priority: Critical > Labels: easyfix > Fix For: 1.0 > > Original Estimate: 1h > Remaining Estimate: 1h > > ImageParser#getBufferedImage() specification tell in documentation : > {code:title=ImageParser#getBufferedImage()|borderStyle=solid} > /** > ... > * @param params Optional instructions for special-handling or > * interpretation of the input data (null objects are > permitted and > * must be supported by implementations). > ... > **/ > {code} > Implementation PngImageParser#getBufferedImage() does note respect this > documentation. Indeed, first line of the function is : > {code:title=PngImageParser#getBufferedImage() line 637 |borderStyle=solid} > if (params.containsKey(PARAM_KEY_VERBOSE)) { > params.remove(PARAM_KEY_VERBOSE); > } > {code} > I suppose It would be > {code:title=FIX PngImageParser#getBufferedImage()|borderStyle=solid} > if (params!=null && params.containsKey(PARAM_KEY_VERBOSE)) { > params.remove(PARAM_KEY_VERBOSE); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)