[ https://issues.apache.org/jira/browse/LANG-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bruno P. Kinoshita updated LANG-1077: ------------------------------------- Attachment: LANG-1077.patch Patch with Haiyang Li code and a unit test. > StringUtils.ordinalIndexOf("aaaaaa", "aa", 2) != 2 in StringUtils > ------------------------------------------------------------------ > > Key: LANG-1077 > URL: https://issues.apache.org/jira/browse/LANG-1077 > Project: Commons Lang > Issue Type: Bug > Components: lang.* > Affects Versions: 3.3.2 > Reporter: haiyang li > Fix For: Discussion > > Attachments: LANG-1077.patch > > > {code:title= org.apache.commons.lang3.StringUtils.java|borderStyle=solid} > int found = 0; > int index = lastIndex ? str.length() : INDEX_NOT_FOUND; > do { > if (lastIndex) { > index = CharSequenceUtils.lastIndexOf(str, searchStr, index - > 1); > } else { > index = CharSequenceUtils.indexOf(str, searchStr, index + 1); > } > if (index < 0) { > return index; > } > found++; > } while (found < ordinal); > {code} > Should it be: > {code:title= org.apache.commons.lang3.StringUtils.java|borderStyle=solid} > int found = 0; > int index = lastIndex ? str.length() : INDEX_NOT_FOUND; > do { > if (lastIndex) { > index = CharSequenceUtils.lastIndexOf(str, searchStr, index - > searchStr.length()); > } else { > index = CharSequenceUtils.indexOf(str, searchStr, index + > searchStr.length()); > } > if (index < 0) { > return index; > } > found++; > } while (found < ordinal); > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)