[
https://issues.apache.org/jira/browse/NET-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282000#comment-14282000
]
Sebb commented on NET-525:
--------------------------
It now appears that adding a method to an interface does not break binary
compatibility [1].
Unfortunately Clirr does not distinguish between source and binary compat. in
the generated report.
URL: http://svn.apache.org/r1652868
Log:
revert r1652867
Removed:
commons/proper/net/trunk/src/main/java/org/apache/commons/net/ntp/NtpV3Packetbis.java
Modified:
commons/proper/net/trunk/src/main/java/examples/ntp/SimpleNTPServer.java
commons/proper/net/trunk/src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java
commons/proper/net/trunk/src/main/java/org/apache/commons/net/ntp/NtpV3Packet.java
commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp/TestNtpPacket.java
commons/proper/net/trunk/src/test/java/org/apache/commons/net/ntp/TestTimeInfo.java
[1] https://docs.oracle.com/javase/specs/jls/se5.0/html/binaryComp.html#45348
> Added missing set methods on NTP class and interface
> ----------------------------------------------------
>
> Key: NET-525
> URL: https://issues.apache.org/jira/browse/NET-525
> Project: Commons Net
> Issue Type: Improvement
> Affects Versions: 3.3
> Reporter: jason mathews
> Labels: ntp
> Fix For: 3.4
>
> Attachments: diff.patch.txt
>
>
> I was the original contributor of the NTP implementation and have recently
> cleaned the source and submitting the relevant changes.
> Here is the summary of changes:
> src/main/java/org/apache/commons/net/ntp/TimeInfo.java
> -Added missing equals() and hashCode() methods
> -Added new method: getAddress()
> src/main/java/org/apache/commons/net/ntp/NtpV3Packet.java
> -Added missing methods: setPrecision(), setRootDelay(), and
> setRootDispersion()
> src/main/java/org/apache/commons/net/ntp/NtpV3Impl.java
> -Added missing equals() and hashCode() methods
> -Added missing set methods: setRootDelay(), setRootDispersion(),
> -Added validation check to setDatagramPacket()
> Added additional tests:
> -src/test/java/org/apache/commons/net/ntp/TestNtpPacket.java
> -src/test/java/org/apache/commons/net/ntp/TestTimeInfo.java
> See attached patch.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
