[ 
https://issues.apache.org/jira/browse/LANG-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299872#comment-14299872
 ] 

Oliver Heger commented on LANG-1085:
------------------------------------

Hi Bruno,

many thanks for your comments!

I like your idea to have several circuit breaker implementations for different 
special purposes. If it was possible to use a common interface, the better. I 
guess such an interface would have methods like {{open()}}, {{close()}}, 
{{isOpen()}}, {{isClosed()}}, {{checkState()}}, {{incrementAndCheckState()}}. 
Do you think this is sufficient, or would we need some more to make this more 
generic (maybe rather than an increment by one, a generic add would be needed?)?

In this respect, renaming the class to {{TimeCircuitBreaker}} would be fine 
with me.

Regarding Java8 Javadoc compatibility: I have to confess that I did not check 
this; so there might be problems.

> Add a circuit breaker implementation
> ------------------------------------
>
>                 Key: LANG-1085
>                 URL: https://issues.apache.org/jira/browse/LANG-1085
>             Project: Commons Lang
>          Issue Type: New Feature
>          Components: lang.concurrent.*
>            Reporter: Oliver Heger
>         Attachments: CircuitBreaker.java, CircuitBreakerTest.java
>
>
> A _circuit breaker_ is a useful component to protect an application against 
> unreliable services or load peaks. A simple implementation could be a good 
> fit for the concurrent package.
> A proposed implementation is attached. Feedback is welcome!



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to