[ 
https://issues.apache.org/jira/browse/COMPRESS-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sebb updated COMPRESS-300:
--------------------------
    Attachment: COMPRESS-300.patch

Patch that makes fields private, adding getters/setters as appropriate.

Note that the getters/setters are adjusted according to the actual usage of the 
original protected fields. 

For example previousCode is only ever set to -1 externally, so it does not need 
a full setter.

Not all the protected fields were originally accessed outside the containing 
class.

> LZWInputStream has mutable protected fields; these should be accessed via 
> getter/setter and made private
> --------------------------------------------------------------------------------------------------------
>
>                 Key: COMPRESS-300
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-300
>             Project: Commons Compress
>          Issue Type: Bug
>            Reporter: Sebb
>         Attachments: COMPRESS-300.patch
>
>
> As per the discussion on the dev list, the class LZWInputStream has some 
> non-private mutable fields.
> These should be accessed via getters/setters only (data encapsulation).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to