[ https://issues.apache.org/jira/browse/LANG-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14328896#comment-14328896 ]
Duncan Jones commented on LANG-1074: ------------------------------------ [~lihy70]: Are you willing to update the patch to address Benedikt's comments? Specifically: - Rename to {{removeAllOccurences(...)}} - Drop the {{boolean removeAll}} parameter. You should also add {{@since 3.4}} to the Javadoc for the new methods. Then we can look to getting this added to trunk. > Add a method to ArrayUtils for removing all occurrences of a given element > -------------------------------------------------------------------------- > > Key: LANG-1074 > URL: https://issues.apache.org/jira/browse/LANG-1074 > Project: Commons Lang > Issue Type: Improvement > Components: lang.* > Affects Versions: 3.3.2 > Reporter: haiyang li > Priority: Minor > Fix For: Review Patch > > Attachments: LANG-1074.patch.txt > > > Could we add the method: removeElementAll to remove all the occurrences of > the specified element from the specified > (boolean/char/byte/short/int/long/float/double/Object) array: > {code:title=org.apache.commons.lang3.ArrayUtils.java|borderStyle=solid} > public static <T> T[] removeElementAll(final T[] array, final Object > element) { > int index = indexOf(array, element); > if (index == INDEX_NOT_FOUND) { > return clone(array); > } > int[] indices = new int[array.length - index]; > int count = 0; > indices[count++] = index; > for (;;) { > index = indexOf(array, element, ++index); > if (index == INDEX_NOT_FOUND) { > break; > } else { > indices[count++] = index; > } > } > return (T[]) removeAll((Object) array, Arrays.copyOfRange(indices, 0, > count)); > } > {code} > or maybe better: > {code:title=org.apache.commons.lang3.ArrayUtils.java|borderStyle=solid} > public static <T> T[] removeElement(final T[] a, final Object element, > boolean removeAll) { > int index = indexOf(a, element); > if (index == INDEX_NOT_FOUND) { > return clone(a); > } else if (!removeAll || index >= a.length - 1) { > return remove(a, index); > } else { > int[] indices = new int[a.length - index]; > int count = 0; > indices[count++] = index++; > > for (int len = a.length; index < len; index++) { > if ((a[index] == null) ? element == null : (element == null ? > false : a[index].equals(element))) { > indices[count++] = index; > } > } > return (T[]) removeAll((Object) a, Arrays.copyOfRange(indices, 0, > count)); > } > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)