[
https://issues.apache.org/jira/browse/IMAGING-165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14332059#comment-14332059
]
Michael Groß edited comment on IMAGING-165 at 2/22/15 6:41 AM:
---------------------------------------------------------------
Based on the result above it seems that someone forget to add this field to
class TiffContents. So I did it. All tests are OK. PR created.
http://github.com/mgmechanics/commons-imaging/tree/IMAGING-165
was (Author: mgmechanics):
Based on the result above it seems that someone forget to add this field to
class TiffContents. So I did it. PR created.
http://github.com/mgmechanics/commons-imaging/tree/IMAGING-165
> TiffReader.Collector adds values to a field List<TiffField> but never uses it
> -----------------------------------------------------------------------------
>
> Key: IMAGING-165
> URL: https://issues.apache.org/jira/browse/IMAGING-165
> Project: Commons Imaging
> Issue Type: Improvement
> Components: Format: TIFF
> Reporter: Michael Groß
> Fix For: Discussion
>
>
> org.apache.commons.imaging.formats.tiff.TiffReader.Collector adds values to a
> field List<TiffField> but never uses it. This could be the cause of some
> problems reported elsewhere.
> TiffReader contains an embedded class named Collector. This class has a
> private field named
> {noformat}
> private static class Collector implements Listener {
> private final List<TiffField> fields = new ArrayList<TiffField>();
> {noformat}
> There are values added in a method named
> {noformat}
> public boolean addField(final TiffField field) {
> fields.add(field);
> return true;
> }
> {noformat}
> This method is the only which uses this field so these values are never used.
> Is there a getter missing? Or was it intended to use these values in class
> TiffContents like "tiffHeader" and "directories"?
> {noformat}
> public TiffContents getContents() {
> return new TiffContents(tiffHeader, directories);
> }
> {noformat}
> At least the method "addField" seems unused but necessary to implement the
> "Listener" interface.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
