[ https://issues.apache.org/jira/browse/LANG-701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501504#comment-14501504 ]
Benedikt Ritter commented on LANG-701: -------------------------------------- Hello [~jamessawle], I've reviewed the changes on github. Could you please clean up the PR so that is does not contain tab characters and no rearragement of code? Thank you! > StringUtils join with var args > ------------------------------ > > Key: LANG-701 > URL: https://issues.apache.org/jira/browse/LANG-701 > Project: Commons Lang > Issue Type: New Feature > Components: lang.* > Reporter: Gabriele Kahlout > Priority: Minor > Fix For: Review Patch > > Attachments: VarArgJoinTest.java > > > {code:java} > final String apple = "apple"; > final String banana = "banana"; > final String orange = "orange"; > final String expected = apple + SPACE + banana + SPACE + orange; > final String actual = join(SPACE, apple, banana, orange); > final int expLength = expected.length(); > final int actLength = actual.length(); > assertEquals(expLength, actLength); > assertEquals(expected, actual); > {code} > I missed the functionality of joining strings with the space separator in one > line. BTW, why space ' ' not a constant field anywhere? -- This message was sent by Atlassian JIRA (v6.3.4#6332)