[
https://issues.apache.org/jira/browse/POOL-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14501850#comment-14501850
]
Marcin Biegan commented on POOL-278:
------------------------------------
It would be great if implementation if StatsStore could be selected via
configuration. This would allow to use a very simple implementation when
performance matters the most, or more complex one when precise measurements are
the key.
Some scenarios:
- exporting a metric via JMX: running average (like with unix load average)
would be preferable because a single number has to tell what was happening
recently
- exporting a metric to e.g. graphite: it would be great to base the value on
only the events which happened between current and previous push to graphite
- when investigating issues it would be preferably to have access to
percentiles, but it's expensive, so might not be required when everything works
smoothly
I stumbled upon this issue because I'm wondering how to expose content of
StatsStore (or capture percentiles), but currently (commons-pool 2.3) it's not
very convenient, or in case of percentiles - possible.
> Allow user provided efficient statistics implementations
> --------------------------------------------------------
>
> Key: POOL-278
> URL: https://issues.apache.org/jira/browse/POOL-278
> Project: Commons Pool
> Issue Type: Improvement
> Affects Versions: 2.3
> Reporter: Bernd Eckenfels
> Priority: Minor
> Labels: performance
> Fix For: 3.0
>
>
> As discussed in POOL-277 there is some possibility to clean up the current
> StatsStore in impl/BaseGenericObjectPool. This would not only allow to get
> rid of the synchronized implementation and strange mean calculation, but also
> allow a user to register a faster or more complete statistics caluculation.
> For this I would suggest to make a Statisctics interface public and allow the
> user to register implementations of this interface for the various tracked
> metrics.
> This new interface should cover count, max, and mean. But the user can also
> directly use the object to ask it for percentile or other information.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
