[ 
https://issues.apache.org/jira/browse/IMAGING-112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14512978#comment-14512978
 ] 

Benedikt Ritter commented on IMAGING-112:
-----------------------------------------

Hello [~kalgon],

patch looks good to me. Can you please add the apache license header to the 
newly added class IptcFullDiscardTest? And please only use spaces for 
indentation.

Thank you!

Benedikt

> JpegIptcRewriter.removeIPTC() does not remove all metadata
> ----------------------------------------------------------
>
>                 Key: IMAGING-112
>                 URL: https://issues.apache.org/jira/browse/IMAGING-112
>             Project: Commons Imaging
>          Issue Type: Improvement
>    Affects Versions: 1.0
>            Reporter: Xavier Dury
>             Fix For: Review Patch
>
>         Attachments: ImageTest.java, patch.txt
>
>
> I'm trying to compute hashes from my images to detect duplicates.
> To do so, I strip every metadata (like keywords I may have added) then 
> compute a CRC32.
> My problem is that JpegIptcRewriter.removeIPTC() does not remove all metadata 
> as there is always a difference of 18 bytes (containing "Photoshop 3.0").
> So could it be possible to remove those 18 bytes as well in removeIPTC() so 
> that I can compute hashes?
> Thanks,
> Xavier



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to