[
https://issues.apache.org/jira/browse/CRYPTO-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355005#comment-15355005
]
Sebb commented on CRYPTO-92:
----------------------------
Looks OK, except the props file overrides system properties; the file load
needs to drop any properties that are also in system properties.
> Handling default properties; allow SystemProperties to be ignored
> -----------------------------------------------------------------
>
> Key: CRYPTO-92
> URL: https://issues.apache.org/jira/browse/CRYPTO-92
> Project: Commons Crypto
> Issue Type: Improvement
> Reporter: Sebb
>
> The code currently checks both local Properties and SystemProperties in
> several places.
> This is unnecessary, as the Properties class already supports the notion of
> property defaults, as these can be passed in to the constructor.
> I think it would be better to drop the specific check of the SystemProperties.
> This would be more flexible, as the user could decide whether or not to allow
> the use of SystemProperties or some other set of defaults.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
