[
https://issues.apache.org/jira/browse/COMMONSRDF-54?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15842935#comment-15842935
]
ASF GitHub Bot commented on COMMONSRDF-54:
------------------------------------------
Github user ghxiao commented on the issue:
https://github.com/apache/commons-rdf/pull/31
I added a test case`RDF4JMethodOverloadsTest` and one more method in RDF4J
`public RDF4JBlankNodeOrIRI asRDFTerm(final
org.eclipse.rdf4j.model.Resource value)`
> overloaded versions of RDF4J#asRDFTerm(org.eclipse.rdf4j.model.Value)
> ---------------------------------------------------------------------
>
> Key: COMMONSRDF-54
> URL: https://issues.apache.org/jira/browse/COMMONSRDF-54
> Project: Apache Commons RDF
> Issue Type: Improvement
> Components: rdf4j
> Reporter: Guohui Xiao
> Priority: Minor
> Fix For: 1.0.0
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> In the class org.apache.commons.rdf.rdf4j.RDF4J, there is a method
> public RDF4JTerm asRDFTerm(final Value value)
> Suppose that we declare a variable iri of the type
> org.eclipse.rdf4j.model.IRI, then asRDFTerm(iri) returns RDF4JTerm but not
> RDF4JIRI. To use the result as RDF4JIRI, I always need to explicitly cast.
> Therefore, I would like to add three overloaded versions of this method:
> - RDF4JBlankNode asRDFTerm(final org.eclipse.rdf4j.model.BNode value)
> - RDF4JLiteral asRDFTerm(final org.eclipse.rdf4j.model.Literal value)
> - RDF4JIRI asRDFTerm(final org.eclipse.rdf4j.model.IRI value)
> So that we can avoid unnecessary casts.
> There is also a similar situation in
> org.apache.commons.rdf.jena.JenaRDF#asRDFTerm(org.apache.jena.graph.Node)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
