[ 
https://issues.apache.org/jira/browse/LANG-1145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875169#comment-15875169
 ] 

ASF GitHub Bot commented on LANG-1145:
--------------------------------------

Github user kinow commented on the issue:

    https://github.com/apache/commons-lang/pull/231
  
    @michael-o 
    
    >What is the real pupose for this actually? The client should not care 
about the arch at all.
    
    I think @Tomschi use case is valid, where a client could need to know the 
arch before loading a certain library, and we had another issue submitted 
LANG-1145 with similar requirement.
    
    >The regex match is brittle. This will likely fail on ARM and it fails here 
on Itanium with HP-UX for os.arch IA64N which is a 32 bit VM.
    
    Note taken, perhaps before merging we can try to cover more archs, like 
this list:
    
    * http://lopica.sourceforge.net/os.html
    
    There is another place where arch is used within Commons too:
    
    * 
https://github.com/apache/commons-crypto/blob/158be0644c353a617427ab190a4f09082cda42ac/src/main/java/org/apache/commons/crypto/OsInfo.java#L28
    
    We can possibly look at how crypto is using it, and if we could maybe use a 
similar approach here.


> 64 bit check in SystemUtils
> ---------------------------
>
>                 Key: LANG-1145
>                 URL: https://issues.apache.org/jira/browse/LANG-1145
>             Project: Commons Lang
>          Issue Type: Improvement
>          Components: lang.*
>            Reporter: Gabor Liptak
>            Priority: Minor
>
> Add is64bit method to SystemUtils.java
> http://stackoverflow.com/a/2269242/304690 for Windows snippet and
> https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/util/SizeEstimator.scala
>  for zOS snippet



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to