[
https://issues.apache.org/jira/browse/CONFIGURATION-653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15895709#comment-15895709
]
Oliver Heger commented on CONFIGURATION-653:
--------------------------------------------
I had a look at the patch and did some experiments; but unfortunately, it
cannot be applied like this because it breaks binary compatibility. Client code
would have to be recompiled, otherwise NoSuchMethodErrors would be thrown. This
is not an option for a minor release in Commons.
What we could do instead is leaving the existing methods in place and add
overloaded variants that operate on {{ImmutableConfiguration}}. The older
methods then just delegate to the new ones. This would add the desired
functionality, but preserves compatibility. WDYT?
> ConfigurationUtils.dump and other methods should use ImmutableConfiguration
> ---------------------------------------------------------------------------
>
> Key: CONFIGURATION-653
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-653
> Project: Commons Configuration
> Issue Type: Bug
> Affects Versions: 2.1, 2.1.1
> Reporter: Vincent Maurin
> Priority: Minor
> Attachments: use_immutable.diff
>
>
> Since the read-only ImmutableConfiguration/ImmutableHierarchicalConfiguration
> has been introduced, several methods that uses Configuration in a read-only
> fashion should be adapted to use these ones instead of the read/write
> alternative.
> For example :
> ConfigurationUtils.dump
> ConfigurationUtils.toString
> ConfigurationUtils.copy (for the source)
> ConfigurationUtils.append (for the source)
> ConfigurationUtils.convertToHierarchical
> ConfigurationConverter.getProperties
> ... and maybe others
> It should not break any existing code as Configuration implements
> ImmutableConfiguration and it could enable code that manipulates read only
> configurations to use these utilities
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
