Github user sebbASF commented on a diff in the pull request:

    https://github.com/apache/commons-lang/pull/231#discussion_r105175128
  
    --- Diff: src/main/java/org/apache/commons/lang3/arch/Processor.java ---
    @@ -0,0 +1,30 @@
    +package org.apache.commons.lang3.arch;
    +
    +/**
    + *
    + */
    +public class Processor {
    +
    +    private String name;
    +    private ProcessorArch processorArch;
    +    private ProcessorType processorType;
    +
    --- End diff --
    
    These should be final.
    I don't think the name is needed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to